Update 05-data-structures-part2.Rmd #452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think for novices the idea of "names(cats)" a longer vector being %in% c("age") a single character vector is extraneous cognitive load. NB the c() is un-necessary too.
More natural just to ask are the names equal "==". Maybe also change "!drop" to "-drop" as that again is consistent with the previous examples of column selection immediately above.
|
@Malarkey73 thanks for the PR! I agree it could be confusing, but the counterargument is that it enables removal of multiple discontiguous columns. The switch from |
|
Good point @Malarkey73 . The |
|
Closing for now, but feel free to re-open after restricting change to updating only the portion about the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think for novices the idea of "names(cats)" a longer vector being %in% c("age") a single character vector is extraneous cognitive load. NB the c() is un-necessary too.
More natural just to ask are the names equal "==". Maybe also change "!drop" to "-drop" as that again is consistent with the previous examples of column selection immediately above.
Please delete the text below before submitting your contribution.
Thanks for contributing! If this contribution is for instructor training, please send an email to checkout@carpentries.org with a link to this contribution so we can record your progress. You’ve completed your contribution step for instructor checkout just by submitting this contribution.
Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact Kate Hertweck (k8hertweck@gmail.com).